D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre created this revision.
davidre added reviewers: kmaterka, broulik, mart, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The engine does complicated logig in order to provide a pre rendered icon.
  However in combination with IconItem this also resulted in bugs causing
  overlay icons to effectively not work (correctly) [1, 2].  This exposes the name and pixmap
  properties in the data engine as in the specification [3]. Displaying of the data
  is now done at the correct layer. The statusnotifertest is additionally extended
  to make testing of all combinations of icon properties easier. For now the old
  combined properties are kept for backwards compatibility but can be removed in
  a later commit or in Plasma 6.
  [1] https://phabricator.kde.org/D28107
  [2] https://phabricator.kde.org/D27617#630440
  [3] https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/

TEST PLAN
  use statusnotifiertest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200322/601a9bef/attachment.html>