D28192: WIP: Refactor dictionary runner

[Alexander Lohnau]

alex created this revision.
alex added reviewers: broulik, ngraham, sitter, mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The config key has been moved to a separate file, some foreach have been refactored, the QRegExp occurrences have been ported to QRegularExpression and are now reused.
  Furthermore unnecessary functions/function calls have been removed and the code is formatted.
  
  WIP: Currently the way the matches look is not very good, because there is far too much text displayed for example:
  F8191533: CurrentStateNormalKWin <https://phabricator.kde.org/F8191533>
  And with a crappy kwin rule which increases the width:
  F8191530: Current <https://phabricator.kde.org/F8191530>
  
  My Idea would be to make the definition, example sentence and synonyms customizable.
  By default the word type, definition and synonyms would be shown for example:
  `n trying something to find out about it [syn: trial, trial run, test, tryout]`
  And also an action which shows a dialog with all the available information and maybe some copy buttons for the synonyms.
  
  Because this patch is refactoring/cleanup I consider making a new patch for these feature and would appreciate feedback for the ideas :-).

TEST PLAN
  Should work as before

REPOSITORY
  R114 Plasma Addons

BRANCH
  dictionary_runner_improvements

REVISION DETAIL
  https://phabricator.kde.org/D28192

AFFECTED FILES
  runners/dictionary/config_keys.h
  runners/dictionary/dictionarymatchengine.cpp
  runners/dictionary/dictionaryrunner.cpp
  runners/dictionary/dictionaryrunner.h
  runners/dictionary/dictionaryrunner_config.cpp
  runners/dictionary/dictionaryrunner_config.h

To: alex, broulik, ngraham, sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200321/eccb45dc/attachment-0001.html>