D28134: Add ColorUtils

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  What's your intended usecase?
  
  Is Kirigami the right place?  The original scope for that was "core application building blocks".

INLINE COMMENTS

> colorutils.cpp:78
> +
> +    if (item->canConvert<QQuickItem*>()) {
> +        auto casted = item->value<QQuickItem*>();

Depending on use case, it might be better to take a QSGTextureProvider

then images can give you a surface directly without the blit, and you can still take composite items through a ShaderEffectSource

> pendingvalue.h:25
> +     */
> +    Q_INVOKABLE QVariant await();
> +

Having a nested event loop called from QML code is really really dangerous.

If you want it for unit tests or something, fine.

Invokable, absolutely not.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28134

To: cblack, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200321/0f02ed42/attachment.html>