D28185: [applet/systemtray] Use model binding instead of copy

Kai Uwe Broulik noreply at phabricator.kde.org
Sat Mar 21 17:20:04 GMT 2020


broulik added inline comments.

INLINE COMMENTS

> AbstractItem.qml:36
>      property Item iconItem
> -    property int /*PlasmaCore.Types.ItemStatus*/ status
> -    property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus
> +    property int /*PlasmaCore.Types.ItemStatus*/ status: model.status ? model.status : PlasmaCore.Types.UnknownStatus
> +    property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus: model.effectiveStatus ? model.effectiveStatus : PlasmaCore.Types.UnknownStatus

You can simplify this to

  model.status || PlasmaCore.Types.UnknownStatus

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28185

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200321/84029256/attachment.html>


More information about the Plasma-devel mailing list