D21905: [Digital Clock] Open KOrganizer with event details on click

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM +1

INLINE COMMENTS

> CalendarView.qml:194
> +                    // showEventDetails introduced in KF5 5.61
> +                    enabled: typeof monthView.daysModel.showEventDetails === "function"
> +

I'd use instanceof.

Also you can depend on a new KF5 anyway, I wouldn't make it optional.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21905

To: dvratil, #plasma
Cc: broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200321/81412f6a/attachment-0001.html>