D28176: Implement Keyboard Keycode support as suggested in the spec

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  I thought I already had support for this, maybe it got lost somewhere. Looks good otherwise.

INLINE COMMENTS

> waylandintegration.cpp:386
> +    if (m_streamInput && m_fakeInput) {
> +        if (state)
> +            m_fakeInput->requestKeyboardKeyPress(keycode);

Nitpick, I use brackets even for ifs with one line of code so if you would be so kind and use brackets to have same coding style.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D28176

To: apol, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200321/a5283047/attachment.html>