D28180: [applets/systemtray] Hide/show expander arrow - regression fix
Konrad Materka
noreply at phabricator.kde.org
Sat Mar 21 11:01:22 GMT 2020
kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson.
kmaterka added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.
REVISION SUMMARY
Expander arrow should hide when all icons are visible and no icon is hidden. When dialog with hidden items is hidden ListView does not update its count property - property is update on redraw. As a result expander arrow is still visible/hidden until user clicks on any plasmoid to show dialog.
TEST PLAN
- select/deselect "Show all items" in settings, save, expander arrow should hide/show imidiatelly
- select almost all items to "Always shown", leave "Keyboard indicator" as "Shown when relevant". Press Casp Lock, expander arrow should hide/show correctly
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28180
AFFECTED FILES
applets/systemtray/package/contents/ui/ExpanderArrow.qml
applets/systemtray/package/contents/ui/HiddenItemsView.qml
To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200321/0769f3db/attachment.html>
More information about the Plasma-devel
mailing list