D27576: Kill Runner: Move config keys to new file

Alexander Lohnau noreply at phabricator.kde.org
Sat Mar 21 07:02:16 GMT 2020


alex marked an inline comment as done.
alex added inline comments.

INLINE COMMENTS

> meven wrote in killrunner.cpp:65
> You can use the enum as default value here I guess : Sort::NONE

What you suggested is not possible, because the enum is not declared as an enum qobject and declaring it just for this one occurrence seems unnecessary to me :-).
But using an int cast of the default value makes the code more readable.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200321/c6919bd8/attachment.html>


More information about the Plasma-devel mailing list