D27166: Refactor converter runner

[Kai Uwe Broulik]

broulik added a comment.


  Very nice! There's two minor nitpicks but then I think it should be good to go, thanks for your endurance :)

INLINE COMMENTS

> converterrunnertest.cpp:50
> +{
> +    setlocale(LC_ALL, "C.utf8");
> +    runner = new ConverterRunner(this, QVariantList());

This doesn't affect translations. I guess you also want to add a

  qputenv("LANG", "en_US")

> converterrunner.cpp:119
> +        if (outputUnit.categoryId() == KUnitConversion::CurrencyCategory) {
> +            outputValue.round(2);
>          }

When there's just one decimal, it doesn't add a zero

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200320/4d9f7f4f/attachment.html>