D28098: remove pointless and arbitrary 4 line frame limit

Ahmad Samir noreply at phabricator.kde.org
Thu Mar 19 21:10:52 GMT 2020


ahmadsamir added a comment.


  This makes sense; also it fixes a part of the backtraceparsertest unit test, test_bug168000, which currently fails on master (output after export'ing QT_LOGGING_RULES="*drkonqi*=true"):
  
    3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) org.kde.drkonqi.parser: Rating: 24 out of 24 Usefulness: Useless
    3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) org.kde.drkonqi.parser: 90%: 21.6 70%: 16.8 40%: 9.6
    3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) org.kde.drkonqi.parser: Have seen stack base: false Lines counted: 3
    3: FAIL!  : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) Compared values are not the same
    3:    Actual   (btUsefulness): "Useless"
    3:    Expected (result)      : "MayBeUseful"
    3:    Loc: [/home/ahmad/rpmbuild/dev/drkonqi/src/tests/backtraceparsertest/backtraceparsertest.cpp(71)]
  
  the rating is perfect but gets killed by the frame number limit.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28098

To: sitter, apol, bcooksley
Cc: ahmadsamir, bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/23099e54/attachment-0001.html>


More information about the Plasma-devel mailing list