D28109: [applets/systemtray] Simplify icon size logic
Konrad Materka
noreply at phabricator.kde.org
Thu Mar 19 17:00:03 GMT 2020
kmaterka added a comment.
In D28109#629974 <https://phabricator.kde.org/D28109#629974>, @ngraham wrote:
> This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup visibility. I can't detect any regressions in sizing with horizontal or vertical panels of various sizes. However please wait to land this until somebody else possessing greater familiarity with this codebase such as @broulik, @mart, or @davidedmundson reviews it too.
@ngraham the problem is when diff is marked as reviewed, they don't see it :)
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28109
To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/11af8347/attachment.html>
More information about the Plasma-devel
mailing list