D27166: Refactor converter runner
Alexander Lohnau
noreply at phabricator.kde.org
Thu Mar 19 15:53:30 GMT 2020
alex added inline comments.
INLINE COMMENTS
> broulik wrote in converterrunner.cpp:74
> There's also units with µ, Ω, . (fl.oz.), not taking into account how those might be localized, so using a very specific regexp looks somewhat brittle to me. Can't really think of a better way, though...
Well the only idea I have is to allow everything as a unit and let the conversion backend decide if it is valid.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D27166
To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/d27fd9e4/attachment.html>
More information about the Plasma-devel
mailing list