D27166: Refactor converter runner

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  Please also add test cases for the regressions Kai highlighted. Thanks!

INLINE COMMENTS

> broulik wrote in converterrunnertest.cpp:75
> I think you should change the locale for the unittest to `C` or `en_US` (dunno how, needs someone with more test knowledge :D) since those are translated and fail when I run the test locally

the servicerunnertest in plasma-workspace is actually doing that by simply calling setlocale I think. that should be good enough so long as it gets called early enough

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/60bf458d/attachment.html>