D28137: make servicerunner only build once
Harald Sitter
noreply at phabricator.kde.org
Thu Mar 19 13:52:16 GMT 2020
sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
build the runner itself in a static lib we can use for testing and then
link that into a module lib together with the factory entry point to
compose the final lib for installation
means servicesrunner.cpp is now only built once, whereas before it was
built twice through 100% duplicative targets
TEST PLAN
test still passes, installing and restarting krunner still yields working service searches
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28137
AFFECTED FILES
runners/services/CMakeLists.txt
runners/services/autotests/CMakeLists.txt
runners/services/plugin.cpp
runners/services/servicerunner.cpp
To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/8411c467/attachment.html>
More information about the Plasma-devel
mailing list