D27166: Refactor converter runner

[Harald Sitter]

sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:23
> +endif()
> \ No newline at end of file


No newline at end of file

> CMakeLists.txt:6
> +ecm_add_test(converterrunnertest.cpp TEST_NAME converterrunnertest LINK_LIBRARIES Qt5::Test krunner_converter_test)
> \ No newline at end of file


No newline at end of file

> converterrunnertest.cpp:42
> +private:
> +    ConverterRunner *runner;
> +};

`= nullptr`

In fact, you could make this a std::unique_ptr because currently it is also not getting deleted, not that it matters for a test ^^

> converterrunnertest.cpp:153
> +#include "converterrunnertest.moc"
> \ No newline at end of file


No newline at end of file

> converterrunner.cpp:83
>  
>  ConverterRunner::~ConverterRunner()
>  {

Seeing as this now doesn't do anything you can `= default` it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/778aa43e/attachment-0001.html>