D28135: Port away from deprecated QSet/QList methods in some places

Ahmad Samir noreply at phabricator.kde.org
Thu Mar 19 11:41:51 GMT 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in runnermodel.cpp:179
> But toSet() returns new container m_runners and runners are unmodified.

I don't mind reverting that bit, but it seems wasteful to me to throw newRunners away, it is sorted and has no duplicates....

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/44c97f81/attachment-0001.html>


More information about the Plasma-devel mailing list