D28135: Port away from deprecated QSet/QList methods in some places

Anthony Fieroni noreply at phabricator.kde.org
Thu Mar 19 11:06:47 GMT 2020


anthonyfieroni added inline comments.

INLINE COMMENTS

> runnermodel.cpp:179
> +    if (currRunners != newRunners) {
> +        m_runners = newRunners;
>  

Here should be `m_runners = runners` to be exactly same as previous. I don't see much benefit of having duplicate items.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/c24c0c61/attachment.html>


More information about the Plasma-devel mailing list