D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Fix those two minor nitpicks and then ship it. Well done!

INLINE COMMENTS

> broulik wrote in abstracttasksmodel.h:99
> `@since 5.19`

This is plasma-workspace, not plasma-framework, so `5.19` it is.

> xwindowtasksmodel.cpp:472
> +{
> +    auto info = windowInfo(window);
> +    return QString::fromUtf8(info->applicationMenuServiceName());

`const KWindowInfo *` to match the rest of the code

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/e1df131f/attachment-0001.html>