D28132: [Calculator Runner] Minor code optimisation
Ahmad Samir
noreply at phabricator.kde.org
Wed Mar 18 17:30:08 GMT 2020
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.
REVISION SUMMARY
Remove redunant QString::contains() checks.
Create one QRegularExpression object and use setPattern().
TEST PLAN
make && ctest
REPOSITORY
R120 Plasma Workspace
BRANCH
l-calcrun (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28132
AFFECTED FILES
runners/calculator/calculatorrunner.cpp
To: ahmadsamir, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200318/409315a4/attachment.html>
More information about the Plasma-devel
mailing list