D28103: Support multiple stacked Passive Notifications

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> PassiveNotification.qml:26
> +
> +    x: parent.width/2 - width/2
> +    y: parent.height - height - Kirigami.Units.smallSpacing

`Math.round` please

> PassiveNotification.qml:35
> +
> +    topPadding: Kirigami.Units.smallSpacing
> +    leftPadding: Kirigami.Units.smallSpacing

Just `padding`?

> PassiveNotification.qml:62
>  
> -        // Only start the timer when the window has focus, to ensure that
> -        // messages don't get missed on the desktop where it's common to
> -        //be working with multiple windows at once
> -        timer.running = Qt.binding(function() {
> -            return root.Window.active;
> +        if (outerLayout.children.length > 3) {
> +            outerLayout.children[0].close();

When I rapidly create new passive popups, I can exceed the limit. Maybe it needs a `while` loop where it closes without animation or something

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200318/c60f4167/attachment-0001.html>