D27857: Port some usage of QRegExp to QRegularExpression
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Wed Mar 18 15:53:25 GMT 2020
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> calculatorrunner.cpp:199
>
> - if (cmd.contains(QRegExp(QStringLiteral("\\d+and\\d+")))) {
> - cmd.replace(QRegExp(QStringLiteral("(\\d+)and(\\d+)")), QStringLiteral("\\1&\\2"));
> + if (cmd.contains(QRegularExpression(QStringLiteral("\\d+and\\d+")))) {
> + cmd.replace(QRegularExpression(QStringLiteral("(\\d+)and(\\d+)")), QStringLiteral("\\1&\\2"));
If you could look into de-duplicating these QRegularExpressions in a separate patch, that would be awesome.
REPOSITORY
R120 Plasma Workspace
BRANCH
l-qregexp-QRE (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27857
To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200318/43ec0df1/attachment.html>
More information about the Plasma-devel
mailing list