D28075: [kstyle] Properly unregister widgets in ShadowHelper

[Ahmad Samir]

ahmadsamir added a comment.


  FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff:
  
    Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault.
    0x00007ffff0c6c770 in qDeleteAll<QMap<QWidget*, KWindowShadow*>::const_iterator> (begin=..., end=...)
        at /usr/include/qt5/QtCore/qalgorithms.h:320
    320             delete *begin;
    (gdb) bt
    #0  0x00007ffff0c6c770 in qDeleteAll<QMap<QWidget*, KWindowShadow*>::const_iterator> (begin=..., end=...)
        at /usr/include/qt5/QtCore/qalgorithms.h:320
    #1  0x00007ffff0c6bdb8 in qDeleteAll<QMap<QWidget*, KWindowShadow*> > (c=...) at /usr/include/qt5/QtCore/qalgorithms.h:328
    #2  0x00007ffff0c69319 in Breeze::ShadowHelper::~ShadowHelper (this=0x547ca0, __in_chrg=<optimized out>)
        at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:106
    #3  0x00007ffff0c69380 in Breeze::ShadowHelper::~ShadowHelper (this=0x547ca0, __in_chrg=<optimized out>)
        at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:107
    #4  0x00007ffff0c701a2 in Breeze::Style::~Style (this=0x547a40, __in_chrg=<optimized out>)
        at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:200
    #5  0x00007ffff0c70206 in Breeze::Style::~Style (this=0x547a40, __in_chrg=<optimized out>)
        at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:202
    #6  0x00007ffff77ff5e8 in QApplication::~QApplication (this=0x7fffffffdd00, __in_chrg=<optimized out>) at kernel/qapplication.cpp:812
    #7  0x0000000000408f65 in main (argc=1, argv=0x7fffffffde58) at /home/ahmad/rpmbuild/dev/kwidgetsaddons/autotests/kdatetimeedittest.cpp:31

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200318/4220ee36/attachment.html>