D28120: [Icons KCM] Floor delegate height
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Mar 18 10:35:49 GMT 2020
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
There's two rows, so if the delegate happens to be at an odd size, both rows would be rounded up, pushing the icons too close to the delegate border.
Since there's already code for unloading the icons that are out of view, nothing should be leaked into the view, even if we now end up having 1 or 2 pixels of the delegates normally out of view visible.
TEST PLAN
5.18 please
Before
F8182640: Screenshot_20200318_113143.png <https://phabricator.kde.org/F8182640>
After
F8182641: Screenshot_20200318_113133.png <https://phabricator.kde.org/F8182641>
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D28120
AFFECTED FILES
kcms/icons/package/contents/ui/main.qml
To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200318/0f1cc90f/attachment-0001.html>
More information about the Plasma-devel
mailing list