D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Roman Gilg]

romangg added a comment.


  So I think of two things to consider:
  
  - How is the overall interaction? Do we want something in line with other systems? Then we should have a lock/unlock rotation workflow where the current rotation orientation is made permanent until the icon is tapped again. Android <https://www.wikihow.tech/Lock-Screen-Orientation-on-Android> and GNOME <https://askubuntu.com/questions/803845/what-process-is-responsible-for-auto-screen-rotation-i-want-to-disable-it-on-1> do it like this.
  - To make this consistent with the KScreen KCM the values should be written to the control file. I.e. your `KScreenDaemon::setAutoRotation` method should call into `ControlConfig::setAutoRotate`. Then it would just change for example when you lock the rotation from auto to manual and the current rotation value is set anyway.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28115

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200318/c6b93376/attachment.html>