D28096: Don't overwrite status

Konrad Materka noreply at phabricator.kde.org
Tue Mar 17 21:54:33 GMT 2020


kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  > The qml checks the value against the enum but updateItemData inserts the string.
  
  These are two different roles:
  "status" with enum value
  "Status" from SNI data
  
  The same happens for "category" role.
  
  And yeah, I know this is confusing... The best would be to remove all unused roles, especially all *Changed. I just copied all from `StatusNotifierItemSource`, some of them are deprecated from Plasma 4 times.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28096

To: davidre, broulik, kmaterka, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200317/1760465b/attachment.html>


More information about the Plasma-devel mailing list