D28109: [applets/systemtray] Simplify icon size logic
Konrad Materka
noreply at phabricator.kde.org
Tue Mar 17 21:43:28 GMT 2020
kmaterka added inline comments.
INLINE COMMENTS
> ExpanderArrow.qml:31
> implicitHeight: implicitWidth
> - visible: root.hiddenLayout.contentItem.children.length > 0
> + visible: root.hiddenLayout.count > 0
>
This fixes issue (regression) with expander arrow not hiding when all items are visible. Probably I should create separate commit...
> ItemLoader.qml:28
> itemLoader.setSource("PlasmoidItem.qml", {
> - "applet": model.applet,
> - "effectiveStatus": model.effectiveStatus
> + "model": model
> })
The `effectiveStatus` was copied from the model, not binded. Separate commit?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28109
To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200317/ee8e790b/attachment-0001.html>
More information about the Plasma-devel
mailing list