D28086: Improve CMake handling of GNOME libraries

Carson Black noreply at phabricator.kde.org
Mon Mar 16 23:45:18 GMT 2020


cblack created this revision.
cblack added reviewers: Plasma, gikari.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  GNOME libraries were being handled in a manner not
  as elegant as possible with CMake's built-in pkgconf handling.
  This patch uses CMake's built-in pkgconf handling to trim excess
  code and improve style (${GTK_LIBRARIES} -> PkgConfig::GTK+3).

TEST PLAN
  See that everything still builds and links as expected.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  color-reload-module/CMakeLists.txt
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/afe145d9/attachment.html>


More information about the Plasma-devel mailing list