D28057: Fix/Allow folderview popup mode icon and list icon size

Nathaniel Graham noreply at phabricator.kde.org
Mon Mar 16 20:41:12 GMT 2020


ngraham added inline comments.

INLINE COMMENTS

> ConfigIcons.qml:229
>              Layout.fillWidth: true
> -            visible: !isPopup || viewMode.currentIndex === 1
> +            visible: true //!isPopup || viewMode.currentIndex === 1
>  

Don't comment out code, just remove it (applies to the next few changes too)

> FolderView.qml:775
>  
>                  function makeIconSize() {
> +//                     if (root.useListViewMode) {

since makeIconSize() now does only one thing, we should probably just remove the function and instead just `iconSize` to `FolderTools.iconSizeFromTheme(plasmoid.configuration.iconSize)` on line 561.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/c7ae1751/attachment-0001.html>


More information about the Plasma-devel mailing list