D27971: Solid-device-automounter/kcm: correctly update automountOn

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> DeviceAutomounterKCM.cpp:66
>  
> -    auto emitChanged = [this] {
> -        m_devices->setAutomaticMountOnLogin(kcfg_AutomountOnLogin->isChecked());
> -        m_devices->setAutomaticMountOnPlugin(kcfg_AutomountOnPlugin->isChecked());
> -        emit markAsChanged();
> -    };
> -
> -    connect(m_devices, &DeviceModel::dataChanged, this, emitChanged);
> +    connect(kcfg_AutomountOnLogin, &QCheckBox::stateChanged, [this](int state) {
> +        m_devices->setAutomaticMountOnLogin(state == Qt::Checked);

Missing this as third parameter

> DeviceAutomounterKCM.cpp:69
> +    });
> +    connect(kcfg_AutomountOnPlugin, &QCheckBox::stateChanged, [this](int state) {
> +        m_devices->setAutomaticMountOnPlugin(state == Qt::Checked);

ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27971

To: meven, bport, #plasma, ervin, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/8adc6f7c/attachment.html>