D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> +project(libcolorreload C)
> +

Why is this needed?

> CMakeLists.txt:3
> +
> +find_package(PkgConfig REQUIRED)
> +include(GNUInstallDirs)

Move to parent CMakeLists.txt

> CMakeLists.txt:4
> +find_package(PkgConfig REQUIRED)
> +include(GNUInstallDirs)
> +

Same

> CMakeLists.txt:6
> +
> +pkg_check_modules (GLIB glib-2.0)
> +pkg_check_modules (GTK gtk+-3.0)

Remove space before `(` and I guess this could also go to parent CMakeLists.txt?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/c3da65df/attachment-0001.html>