D28074: [kstyle] Avoid invalid iterators in qDeleteAll

[Vlad Zahorodnii]

zzag added a comment.


  In D28074#628308 <https://phabricator.kde.org/D28074#628308>, @broulik wrote:
  
  > It would be nice not to mutate a list that's being deleted
  
  
  Well, we could do something like this (not sure whether it works though)
  
    for (KWindowShadow *shadow : _shadows)
        disconnect(shadow, nullptr, this, nullptr);
    
    qDeleteAll(_shadows);
  
  or switch to QPointers

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D28074

To: zzag, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/a8e61e5b/attachment.html>