D28074: [kstyle] Avoid invalid iterators in qDeleteAll

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  When a KWindowShadow object is destroyed, it's automatically removed
  from _shadows and therefore iterators become invalid. This may cause
  problems when one is using qDeleteAll because the latter assumes that
  the passed container won't change.

TEST PLAN
  Applications don't crash when switching from Oxygen to
  Breeze widget style.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D28074

AFFECTED FILES
  kstyle/oxygenshadowhelper.cpp

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/c723a9d2/attachment-0001.html>