D28073: [kstyle] Properly unregister widgets in ShadowHelper

Vlad Zahorodnii noreply at phabricator.kde.org
Mon Mar 16 13:18:06 GMT 2020


zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  After a widget has been unregistered, a WinIdChange event may be sent.
  If that happens, ShadowHelper is going to try to install a shadow for
  the corresponding widget. Obviously, this is wrong.

TEST PLAN
  Added a qDebug in ~ShadowHelper to ensure that _shadows is
  empty.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D28073

AFFECTED FILES
  kstyle/oxygenshadowhelper.cpp

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/57af6b79/attachment.html>


More information about the Plasma-devel mailing list