D28042: [DrKonqi] Port QRegExp to QRegularExpression

Harald Sitter noreply at phabricator.kde.org
Mon Mar 16 10:58:37 GMT 2020


sitter added a comment.


  I wouldn't terribly mind a second pair of eyes.
  
  Code generally looks good to me though, so if nobody else comments feel free to land in a couple days.

INLINE COMMENTS

> backtraceparsergdb.cpp:55
> +    // "#5  0x00007f50e99f776f in QWidget::testAttribute_helper (this=0x6e6440,\n    attribute=Qt::WA_WState_Created) at kernel/qwidget.cpp:9081\n"
> +    // gdb breaks long stack frame lines into multiple ones to readability
> +    regExp.setPatternOptions(QRegularExpression::DotMatchesEverythingOption);

s/to/for?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28042

To: ahmadsamir, #plasma, davidedmundson, sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/c1d8ae8e/attachment.html>


More information about the Plasma-devel mailing list