D28066: Remove the STATIC_LIBRARY option to fix static builds
Charles Barto
noreply at phabricator.kde.org
Mon Mar 16 03:07:14 GMT 2020
bartoc created this revision.
bartoc added a reviewer: Kirigami.
bartoc added a project: Kirigami.
Herald added a subscriber: plasma-devel.
bartoc requested review of this revision.
REVISION SUMMARY
Previously static builds were broken because
GenerateExportHeader used:
get_property(type TARGET ${TARGET_LIBRARY} PROPERTY TYPE)
which returns STATIC_LIBRARY, however since we had an
option of the same name that variable was "dobule expanded"
in if statements, breaking GenerateExportHeader's logic
Additionally remove the legacy style elseif(...) and endif(...) form
conditionals
fixes https://bugs.kde.org/show_bug.cgi?id=418905
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D28066
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
To: bartoc, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200316/bef05cd4/attachment.html>
More information about the Plasma-devel
mailing list