D28064: [applet/notes] Show a "remove" button on the button row

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  I've personally observed various users struggle to remove a Sticky Note widget, and heard
  anedcotal user reports about this too. Some people look for a close button and don't 
  find one, never thinking to press-and-hold or right-click. Some people do right-click
  but right-click in the content area rather than the frame (which look identical), and see
  the context menu for the text rather than the widget itself.
  
  This patch alleviates this user confusion by adding a Remove button on the button
  row on the bottom of the widget, next to the Configure... button. This makes it
  very easy to remove a Sticky Note. This is not destructive because there's an undo, so
  it's not a big deal if someone clicks the button by mistake.
  
  It could be argued that this makes the applet inconsistent with other widgets which do
  not display visible Remove buttons, which is true. However the nature of the Sticky
  Note applet is that it is likely to be used in a more transient or temporary manner than
  other widgets; it often has more in common with a temporary document than a permanent
  fixture of your desktop. For this reason, I believe it is appropriate to show a visible
  Remove button on the widget.

TEST PLAN
  F8177920: Get rid of it.png <https://phabricator.kde.org/F8177920>

REPOSITORY
  R114 Plasma Addons

BRANCH
  show-remove-button-too (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28064

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200315/38089cf2/attachment.html>