D28034: [WIP] [Applet] Port to ExpandableListItem

Nathaniel Graham noreply at phabricator.kde.org
Fri Mar 13 17:26:57 GMT 2020


ngraham created this revision.
ngraham added reviewers: VDG, Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
ngraham requested review of this revision.

REVISION SUMMARY
  Depends on D28033 <https://phabricator.kde.org/D28033>
  
  WIP because there are two remaining visual glitches I have not yet figured out:
  
  - The expanded view does not get the correct height, so it can overlap the items below it and the highlight effect is not big enough
  - Clicking the Connect button does not show the expanded view automatically as it should
  
  Assistance with these issues would be appreciated

TEST PLAN
  All functionality still works. Other than the WIP items listed above,There are minimal
  visual changes, mostly little things to make the appearance consistent with other
  applets using the new `ExpandableListItem` component.
  
  F8174625: Networks.webm <https://phabricator.kde.org/F8174625>

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28034

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

To: ngraham, #vdg, #plasma, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200313/782f3e9c/attachment.html>


More information about the Plasma-devel mailing list