D28026: further constrict line parsing of .so files

[Harald Sitter]

sitter created this revision.
sitter added reviewers: cfeck, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  As seen in https://bugs.kde.org/show_bug.cgi?id=417435 the previous fix
  for .so detection actually falls flat on the face for most things
  other than glib2. The original test here was flawed as libglib-2.0.so.0
  has the complete suffix '0.so.0' which matched the original parsing
  condition. most libraries however are libfoo.so.0 and for that the suffix
  would be 'so.0' which did not match the original condition.
  
  extend the condition to properly cover files without so-version, files with
  awkward suffix (such as glib) and files with normal names and normal
  versioning.
  also extend test case accordingly
  
  CCBUG: 418538

TEST PLAN
  test passes. all lines from 417435 score less than `Good`

REPOSITORY
  R871 DrKonqi

BRANCH
  parse

REVISION DETAIL
  https://phabricator.kde.org/D28026

AFFECTED FILES
  src/parser/backtraceparsergdb.cpp
  src/tests/gdbbacktracelinetest.cpp

To: sitter, cfeck, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200313/d79ba362/attachment.html>