D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, VDG, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The current "Excluded folders" list in the KCM is quite awkward:
  
  1. It tries to mimic baloos automatic exclusion of external drives, but fails doing so and adds almost any external drive even when not mounted below an indexable path.
  
  2. Deleting an autogenerated entry actually **adds** it to the included folder list, and then hides it.
  
  3. There is no way to show the included folder list, or add any entries to it.
  
  Remove the custom "excluded mounts" heuristic from the KCM and retrieve
  the additional (not explicitly configured) excluded ones from baloo.
  
  Replace the "excluded list" with a common list for included and excluded
  folders, and flag its state. This also makes it easy to add additional
  properties later.
  
  Create a new UI delegate for each config list item, allowing to enable
  and disable indexing for each entry. Make the "delete" actually always
  delete a config entry, and make the control inline. Move the "Add" button
  to the *right* bottom of the list (in accordance with UI guidelines) and
  add some text to it.
  
  Depends on D28024 <https://phabricator.kde.org/D28024>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  baloo_config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28025

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: bruns, #baloo, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200313/33ea9424/attachment-0001.html>