D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Mar 12 12:24:18 GMT 2020


apol added inline comments.

INLINE COMMENTS

> kstart.cpp:184
> +        const QRegularExpression re(QRegularExpression::anchoredPattern(windowtitle.toLower()));
> +        if (!re.match(title).hasMatch()) {
> +            return; // no match

Wouldn't it be easier here to just do `windowtitle.compare(info.name(), Qt::CaseInsensitive)` and skip the regex?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28000

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200312/e9c32caa/attachment.html>


More information about the Plasma-devel mailing list