D27954: appstreamrunner: Port to KApplicationTrader

David Faure noreply at phabricator.kde.org
Thu Mar 12 01:30:19 GMT 2020


dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appstreamrunner.cpp:102
> +                return true;
> +            } else {
> +                const auto renamedFrom = service->property("X-Flatpak-RenamedFrom").toStringList();

For symmetry I would have removed the "else" altogether, there are many other cases of if()+return above already, no need to do things differently here.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27954

To: apol, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200312/3072a5a7/attachment.html>


More information about the Plasma-devel mailing list