D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:4897
> +
> +        auto palette = toolbar->palette();
> +        palette.setColor( QPalette::Window, _toolsAreaManager->background(widget) );

This should move in the if condition below. Creating a new palette (even by copy) is expensive. 
When you use the palette.color( QPalette::Window) later in line 4909, you should use the color directly instead, namely _toolsAreaManager->background(widget) (which you can evaluate here already before entering the if loop. This should be cheaper.

> breezestyle.cpp:4933
> +        QRectF copy(widget->geometry());
> +        copy.setTop(widget->childrenRect().top());
> +

another case where it is probably more correct to use option->rect directly.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200311/245908cf/attachment.html>