D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> cblack wrote in breeze.h:104
> This is part of the visual changes of the tools area design—extra spacing as to prevent ugly border on border action.

Why would this be more "ugly" as when there was no toolarea ? can you post a screeshot of the said ugliness ?

> breezetoolsareamanager.cpp:15
> +    ToolsAreaManager::~ToolsAreaManager() {
> +        for (auto entry : animationMap) {
> +            delete entry.foregroundColorAnimation;

This is not needed. Since all animations are created as children of the ToolsAreaManager, they should be deleted automatically when this one is destroyed. 
This way you can simply remove the class destructor altogether and rely on the default one (from QObject).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200310/b5cb0774/attachment.html>