D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D27669#625338 <https://phabricator.kde.org/D27669#625338>, @ngraham wrote:
  
  > FWIW, I'm okay making this configurable, as I do admit that it could be a very polarizing change. We do intend to change the default Breeze color scheme itself to use a light gray for the titlebar, but yes, I understand that people who prefer very dark or bold titlebar colors in an otherwise light color scheme might not like the change, and they should be able to disable this without ditching Breeze entirely.
  >
  > However it's also worth mentioning that there's been a persistent request for exactly that appearance, as some people really seem to like a strongly-colored top area and I anticipate that they'll enjoy using this with a color scheme like Honeycomb.
  
  
  I doubt it. did you actually try ? 
  The active window decoration and the highlight color are the same in honey comb. Meaning that you have essentially no more mouse-over effect or focus effects in toolbars and menubars (see:

INLINE COMMENTS

> breezestyle.cpp:4579
> +
> +        QRectF copy(widget->geometry());
> +        copy.setTop(widget->childrenRect().top());

Are you sure about the logic here ? geometry is relative to the parent corrdinate system while childrenRect is relative to current widget. 
Also, I would as expected that opt->rect would have been enough in any case without the need to resort to the widget accessors

> breezestyle.cpp:4910
> +
> +        QRectF copy(widget->geometry());
> +        copy.setTop(widget->childrenRect().top() - 10);

Same remark as above.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200310/65001f78/attachment-0001.html>