D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D27669#625270 <https://phabricator.kde.org/D27669#625270>, @IlyaBizyaev wrote:
  
  > For color schemes that have contrasting titlebar and content colors, this patch makes application headers look giant...
  >  F8168755: photo_2020-03-10_15-09-54.jpg <https://phabricator.kde.org/F8168755>
  >  It does look good with the proposed default color palette, but it makes many others, including current Breeze, look like an ugly CSD parody :/
  
  
  yes. It also breaks menubar/toolbar highlight and mouse-over when the corresponding colors are similar to the active window color. 
  (oxygen color scheme for instance). I was about to comment on this next. I think the only way for this to work is for breeze to completely ignore the decoration colors, and calculate its own, based on QPalette::Window and WindowText colors. 
  The same way as oxygen style was doing to ensure proper blend of the decoration and main window. 
  Now you can also add an option to force respecting the decoration colors, (oxygen style has such an option), but then it is the responsibility of the use who checks this to fix her/his colorscheme accordingly.
  
  Concerning window border, I think that there is no choice but to disable this entirely if the window borders are not "none" or "no side". 
  And in fact, having a user option to disable this anyway in the config might be needed. This is a quite intrusive change, and many (me included) might want to live without.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200310/6b935bcc/attachment.html>