D27823: Use consistent highlight
George Vogiatzis
noreply at phabricator.kde.org
Tue Mar 10 09:44:26 GMT 2020
gvgeo added a comment.
Couple of notes, as I'm not sure what the aim was here. I have not test it, take them with a grain of salt.
- Highlight area was changed, without changing the click area.
- Connect button pop up area change, was not documented.
- Highlight svg is not consistent with list's highlight. And maybe not always look good. (Although it's designation is pressed, everywhere used as highlight, which is an different story itself.)
- There is code left in various places, listitem.qml possibly could be removed completely now.
---
The line above, is because you did not build plasma-nm but instead copied the qml files.
See T10470 <https://phabricator.kde.org/T10470> for the icon size.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D27823
To: niccolove, jgrulich, #vdg, ngraham
Cc: gvgeo, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200310/228b1e0c/attachment-0001.html>
More information about the Plasma-devel
mailing list