D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  The toolbar background seems to be broken when there are multiple toolbars in the same row.
  See, e.g. ktorrent:
  F8168244: Screenshot_20200309_213717.png <https://phabricator.kde.org/F8168244>
  Does not happen for applications that have a single toolbar (most applications these days)
  Or multiple toolbars but one per row.
  Also happens with kdevelop, or konqueror.
  Then also there are problems with colors (for all color schemes that have strong contrast between window decoration and window). But should be discussed once the above is fixed.

INLINE COMMENTS

> breezestyle.h:505
> +        //* signal manager for the tools area
> +        ToolsAreaManager* _toolsAreaManager;
> +

Should initialize there to null ptr (like the other members). This ensures that you don't have a dangling pointer if for some reason someone deletes the initialization with new in the styles constructor.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200310/27c685be/attachment-0001.html>