D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

Méven Car noreply at phabricator.kde.org
Mon Mar 9 22:01:24 GMT 2020


meven added inline comments.

INLINE COMMENTS

> fonts.cpp:678
>  
> -QFont KFonts::applyFontDiff(const QFont &fnt, const QFont &newFont, int fontDiffFlags)
> -{
> -    QFont font(fnt);
> -
> -    if (fontDiffFlags & KFontChooser::FontDiffSize) {
> -        font.setPointSizeF(newFont.pointSizeF());
> -    }
> -    if ((fontDiffFlags & KFontChooser::FontDiffFamily)) {
> -        font.setFamily(newFont.family());
> -    }
> -    if (fontDiffFlags & KFontChooser::FontDiffStyle) {
> -        font.setWeight(newFont.weight());
> -        font.setStyle(newFont.style());
> -        font.setUnderline(newFont.underline());
> -        font.setStyleName(newFont.styleName());
> +        // Try to find a fixed-width/monspace font from the font family the user selected, e.g.:
> +        // "Noto Sans" -> "Noto Sans Mono", "Ubuntu" -> "Ubuntu Mono"

s/monspace/monospace

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200309/d4c2b614/attachment.html>


More information about the Plasma-devel mailing list