D27943: [Gtk Config] Port fonts sync to KConfigWatcher

Mikhail Zolotukhin noreply at phabricator.kde.org
Mon Mar 9 16:15:54 GMT 2020


gikari added inline comments.

INLINE COMMENTS

> ngraham wrote in gtkconfig.h:89
> `onKcmInputSettingsChange` (capitalize the I in Input)
> 
> Maybe also capitalize KCM?
> 
> Or maybe call it `onCursorSettingsChange`

This name comes from configuration file name and this function (theoretically) triggers on every change of the config, not necessary on cursor theme change, so I think that naming it `onCursorSettingsChange` is not very fair.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27943

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200309/7cd05d04/attachment.html>


More information about the Plasma-devel mailing list