D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

Konrad Materka noreply at phabricator.kde.org
Mon Mar 9 12:43:12 GMT 2020


kmaterka added a comment.


  In D27466#624574 <https://phabricator.kde.org/D27466#624574>, @broulik wrote:
  
  > > I believe that D26992 <https://phabricator.kde.org/D26992>, moves the icons down.
  >
  > It looks like with that patch the icon sizes differ between plasmoids and SNIs
  
  
  That was my work, definitely that should not be the outcome. :) I will check it.
  
  The main problem here is that itemSize (regardless if it is plasmoid or SNI) is calculated in a very complicated and tricky way. If I remember correctly, firstly icon size is calculated, then margin is added but it is not a real margin - simply SNI icons are rounded to closes icon size and then by happy coincident we get margin. I guess it needs to be reworked... I can do that, just need few days for investigation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200309/23b09a7b/attachment.html>


More information about the Plasma-devel mailing list